Skip to content

Support hex transaction types in fromTransactionType#861

Merged
joaquim-verges merged 1 commit intomainfrom
Support_hex_transaction_types_in_fromTransactionType
Mar 3, 2025
Merged

Support hex transaction types in fromTransactionType#861
joaquim-verges merged 1 commit intomainfrom
Support_hex_transaction_types_in_fromTransactionType

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 3, 2025

Changes

How this PR will be tested

  • Open the dashboard and click X. Result: A modal should appear.
  • Call the /foo/bar API. Result: Returns 200 with "baz" in the response body.

Output

(Example: Screenshot/GIF for UI changes, cURL output for API changes)


PR-Codex overview

This PR modifies the src/shared/utils/sdk.ts file by enhancing the fromTransactionType function and removing the toTransactionType function, streamlining transaction type handling.

Detailed summary

  • Added hexToNumber and isHex imports from thirdweb.
  • Updated fromTransactionType to convert hex transaction types using hexToNumber.
  • Removed the entire toTransactionType function.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants